[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1522912405 My local CI https://dev.azure.com/fredia/flink/_build/results?buildId=518=results has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1522731230 @reswqa Thanks for the detailed review, fixed as suggested, please help take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1521455180 @jiexray @reswqa Thanks for the review, I updated the PR according to your suggestions, please help take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1517477103 @snuyanzin could you please help take a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
