[GitHub] [flink] godfreyhe commented on a change in pull request #12610: [FLINK-17686][doc] Add document to dataGen, print, blackhole connectors
godfreyhe commented on a change in pull request #12610:
URL: https://github.com/apache/flink/pull/12610#discussion_r439897020
##
File path: docs/dev/table/connectors/print.md
##
@@ -0,0 +1,144 @@
+---
+title: "Print SQL Connector"
+nav-title: Print
+nav-parent_id: sql-connectors
+nav-pos: 5
+---
+
+
+Sink: Bounded
+Sink: UnBounded
+
+* This will be replaced by the TOC
+{:toc}
+
+The Print connector allows for writing every row to the standard output or
standard error stream.
+
+It is designed for:
+
+- Easy test for streaming job.
+- Very useful in production debugging.
+
+Four possible format options:
+
+
+
+
+Print
+Condition1
+Condition2
+
+
+
+
+ PRINT_IDENTIFIER:taskId> output
+ PRINT_IDENTIFIER provided
+ parallelism > 1
+
+
+ PRINT_IDENTIFIER> output
+ PRINT_IDENTIFIER provided
+ parallelism == 1
+
+
+ taskId> output
+ no PRINT_IDENTIFIER provided
+ parallelism > 1
+
+
+ output
+ no PRINT_IDENTIFIER provided
+ parallelism == 1
+
+
+
+
+The output string format is "$row_kind(f0,f1,f2...)", row_kind is the short
string of [RowKind]({{ site.baseurl
}}/api/java/org/apache/flink/types/RowKind.html), example is: "+I(1,1)".
+
+The Print connector is built-in.
+
+Attention Print sink print records in
tasks, you need to observe the task log.
Review comment:
nit: Print sink print ... -> Print sink prints ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12610: [FLINK-17686][doc] Add document to dataGen, print, blackhole connectors
godfreyhe commented on a change in pull request #12610:
URL: https://github.com/apache/flink/pull/12610#discussion_r439401778
##
File path: docs/dev/table/connectors/print.md
##
@@ -0,0 +1,144 @@
+---
+title: "Print SQL Connector"
+nav-title: Print
+nav-parent_id: sql-connectors
+nav-pos: 5
+---
+
+
+Sink: Bounded
+Sink: UnBounded
+
+* This will be replaced by the TOC
+{:toc}
+
+The Print connector allows for writing every row to the standard output or
standard error stream.
+
+It is designed for:
+
+- Easy test for streaming job.
+- Very useful in production debugging.
+
+Four possible format options:
+
+
+
+
+Print
+Condition1
+Condition2
+
+
+
+
+ PRINT_IDENTIFIER:taskId> output
+ PRINT_IDENTIFIER provided
+ parallelism > 1
+
+
+ PRINT_IDENTIFIER> output
+ PRINT_IDENTIFIER provided
+ parallelism == 1
+
+
+ taskId> output
+ no PRINT_IDENTIFIER provided
+ parallelism > 1
+
+
+ output
+ no PRINT_IDENTIFIER provided
+ parallelism == 1
+
+
+
+
+The output string format is "$row_kind(f0,f1,f2...)", row_kind is the short
string of
[RowKind](https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/types/RowKind.html),
example is: "+I(1,1)".
Review comment:
The url should be changed with flink version. such as for 1.11,
`flink-doces-master` should be changed to `flink-docs-release-1.11`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12610: [FLINK-17686][doc] Add document to dataGen, print, blackhole connectors
godfreyhe commented on a change in pull request #12610:
URL: https://github.com/apache/flink/pull/12610#discussion_r439172876
##
File path: docs/dev/table/connectors/datagen.md
##
@@ -0,0 +1,149 @@
+---
+title: "DataGen SQL Connector"
+nav-title: DataGen
+nav-parent_id: sql-connectors
+nav-pos: 4
+---
+
+
+Scan Source: Bounded
+Scan Source: UnBounded
+
+* This will be replaced by the TOC
+{:toc}
+
+The Datagen connector allows for reading by data generation rules.
+
+The Datagen connector can work with [Computed Column syntax]({{ site.baseurl
}}/dev/table/sql/create.html#create-table).
+This allows you to generate records flexibly.
+
+The Datagen connector is built-in.
+
+Attention Not support complex types:
Array, Map, Row. Please construct these types by computed column.
+
+How to create an Datagen table
+
+
+For each field, there are two ways to generate data:
+
+- Random generator: default, you can specify random max and min values. For
char/varchar/string, the length can be specified.
+- Sequence generator: you can specify sequence start and end values.
Review comment:
explain more about the behavior of after reaching the end value ?
##
File path: docs/dev/table/connectors/print.md
##
@@ -0,0 +1,119 @@
+---
+title: "Print SQL Connector"
+nav-title: Print
+nav-parent_id: sql-connectors
+nav-pos: 5
+---
+
+
+Sink: Bounded
+Sink: UnBounded
+
+* This will be replaced by the TOC
+{:toc}
+
+The Print connector allows for writing every row to the standard output or
standard error stream.
+
+It is designed for:
+
+- Easy test for streaming job.
+- Very useful in production debugging.
+
+Four possible format options:
+
+- PRINT_IDENTIFIER:taskId> output <- PRINT_IDENTIFIER provided, parallelism >
1
+- PRINT_IDENTIFIER> output <- PRINT_IDENTIFIER provided, parallelism
== 1
+- taskId> output <- no PRINT_IDENTIFIER provided,
parallelism > 1
+- output <- no PRINT_IDENTIFIER provided,
parallelism == 1
+
+The output string format is "$RowKind(f0,f1,f2...)", example is: "+I(1,1)".
Review comment:
explain more about RowKind here or give a link where already explained
it?
##
File path: docs/dev/table/connectors/print.md
##
@@ -0,0 +1,119 @@
+---
+title: "Print SQL Connector"
+nav-title: Print
+nav-parent_id: sql-connectors
+nav-pos: 5
+---
+
+
+Sink: Bounded
+Sink: UnBounded
+
+* This will be replaced by the TOC
+{:toc}
+
+The Print connector allows for writing every row to the standard output or
standard error stream.
+
+It is designed for:
+
+- Easy test for streaming job.
+- Very useful in production debugging.
+
+Four possible format options:
+
+- PRINT_IDENTIFIER:taskId> output <- PRINT_IDENTIFIER provided, parallelism >
1
Review comment:
The web display is not friendly
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
