[GitHub] [flink] godfreyhe commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan
godfreyhe commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-818516623 My private azure is green: https://dev.azure.com/godfreyhe/godfreyhe-flink/_build/results?buildId=391=results, the failure test has nothing to do with this change. I will merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan
godfreyhe commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-818431839 @YuvalItzchakov , you can create a new pr to cherry pick this pr to 1.12 once this one is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan
godfreyhe commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-818423595 AFAK, very few connectors implement filter push down. If any one needs this fix in 1.12, we can cherry pick it to 1.12. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan
godfreyhe commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-818413113 @YuvalItzchakov master (1.13 now) is enough, do do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan
godfreyhe commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-818400010 @YuvalItzchakov Thanks for the quick update, I will do a minor improvement in my local: extract a base test class for PushFilterInCalcIntoTableSourceRuleTest, PushFilterIntoLegacyTableSourceScanRuleTest and PushFilterIntoTableSourceScanRuleTest, and will merge this pr once the test is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
