[GitHub] [flink] hameizi commented on pull request #15564: [FLINK-22207][connectors/hive]Hive Catalog retrieve Flink Properties …

[GitBox]

hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-819268640


   > @hameizi If you want to fix this in 1.12.3, you can also create a PR 
against release-1.12 branch.
   
   ok, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] hameizi commented on pull request #15564: [FLINK-22207][connectors/hive]Hive Catalog retrieve Flink Properties …

[GitBox]

hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-819246948


   @KurtYoung I fix in the new commit, please review thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] hameizi commented on pull request #15564: [FLINK-22207][connectors/hive]Hive Catalog retrieve Flink Properties …

[GitBox]

hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-818720129


   @KurtYoung Hello, i push a new commit, thanks for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] hameizi commented on pull request #15564: [FLINK-22207][connectors/hive]Hive Catalog retrieve Flink Properties …

[GitBox]

hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-818406172


   @KurtYoung I add test case in new commit. Please review. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] hameizi commented on pull request #15564: [FLINK-22207][connectors/hive]Hive Catalog retrieve Flink Properties …

[GitBox]

hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-817708105


   > Thanks for the fix, could you add a test case?
   
   hello , I test the fix in sql-client 
   "clickhousetableflink_append_stream" have propertie 
url'='jdbc:clickhouse://host:port/default , and then execute sql like below
   **Flink SQL>** alter table clickhousetableflink_append_stream set 
('flink.url'='jdbc:clickhouse://host:port/default?socket_timeout=30');
   [INFO] Alter table succeeded!
   **Flink SQL>** drop table clickhousetableflink_append_stream;
   [ERROR] Could not execute SQL statement. Reason:
   java.lang.IllegalStateException: Duplicate key 
jdbc:clickhouse://host:port/default


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org