[GitHub] [flink] huwh commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corre

[via GitHub]

huwh commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1128938614


##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##
@@ -95,8 +95,7 @@ private CompletableFuture> 
getPreferredLocations
 // consumers compared to the consumed partition group size. This 
is to avoid tasks
 // unevenly distributed on nodes when running batch jobs or 
running jobs in
 // session/standalone mode.
-if ((double) consumedPartitionGroup.getConsumerVertexGroup().size()
-/ consumedPartitionGroup.size()
+if (consumedPartitionGroup.getConsumerVertexGroup().size()

Review Comment:
   typo: i -> in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] huwh commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corre

[via GitHub]

huwh commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1125845041


##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##
@@ -35,7 +35,7 @@
 
 /**
  * Default implementation of {@link PreferredLocationsRetriever}. Locations 
based on state will be
- * returned if exist. Otherwise locations based on inputs will be returned.
+ * returned if existed. Otherwise, locations based on inputs will be returned.

Review Comment:
   should be "exists"



##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##
@@ -95,8 +95,7 @@ private CompletableFuture> 
getPreferredLocations
 // consumers compared to the consumed partition group size. This 
is to avoid tasks
 // unevenly distributed on nodes when running batch jobs or 
running jobs in
 // session/standalone mode.
-if ((double) consumedPartitionGroup.getConsumerVertexGroup().size()
-/ consumedPartitionGroup.size()
+if (consumedPartitionGroup.getConsumerVertexGroup().size()

Review Comment:
   The description should also be updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org