[GitHub] [flink] jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new
mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#issuecomment-559754634
> I'm only not sure how to register a new Task `Gauge` `isBackPressured` in
the `TaskIOMetricGroup`. I think this needs some refactoring in the future, but
for now could you register the metric in the following way inside the `Task`
constructor:
>
> ```
>this.metrics = metricGroup;
>metricGroup.gauge("isBackPressured", new
BackPressureGauge(this));
> ```
>
> Follow up work would be to introduce `TaskIOMetricGroupBuilder`, created
in the `TaskExecutor`, which is passed to the `Task`. `Task` would add, the
backpressure gauge to the builder and final `TaskIOMetricGroup` would be
constructed/built in the `TaskExecutor` after constructing the `Task`.
I have seen the code， to register it in TaskIOMetricGroup will change more.
| agree with your method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1… URL: https://github.com/apache/flink/pull/10247#issuecomment-559737203 Ok, I'll register it in TaskIOMetricGroup . As you say, here just one metric, so needn't add one group for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1… URL: https://github.com/apache/flink/pull/10247#issuecomment-559726896 Mainly because of backpressure metric is in NettyShuffleMetricFactory, which leads to dependence on Task, do I need to create a new metric factory for backpressure metric? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
jinglining commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1… URL: https://github.com/apache/flink/pull/10247#issuecomment-559642356 could we create a new metrics called BackPressMetrics for it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
