[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-29 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-547278473
 
 
   > screenshot
   > 
   > running
   > 
   > 
![image](https://user-images.githubusercontent.com/3992588/67187115-1c259f00-f41c-11e9-8fae-f49830832139.png)
   > 
   > created
   > 
   > 
![image](https://user-images.githubusercontent.com/3992588/67187149-2d6eab80-f41c-11e9-8dda-3a8ec46cd38e.png)
   
   @zentol I updated the screenshot, is there any problems? Could you give me 
some advice if possible? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-22 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544829219
 
 
   CI failed because FlinkKafkaProducerBase error, ignore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-22 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544828493
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-21 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544397786
 
 
   The previous design in ths PR is following the blink version UX which may 
not get enough feedbacks before. 
   
   After trying both Robert and zentol's UX suggestion in my local development, 
I think "..." with dropdown is better since it would give a much more clear 
meanings for users and save the limited space at the same time.
   
   I have updated the screenshot and code, thanks a lot for your advices.
   
   cc @zentol @rmetzger 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-21 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544397527
 
 
   screenshot
   
   running
   
   
![image](https://user-images.githubusercontent.com/3992588/67187115-1c259f00-f41c-11e9-8fae-f49830832139.png)
   
   created
   
   
![image](https://user-images.githubusercontent.com/3992588/67187149-2d6eab80-f41c-11e9-8dda-3a8ec46cd38e.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-20 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544329926
 
 
   > Could we not update the `host` column to include the port (like on the 
taskmanagers page) and link to the TaskManager page? Wouldn't this effectively 
work like the current iteration, just without an additional column?
   
   Like this:
   
![image](https://user-images.githubusercontent.com/3992588/67173579-b7554f00-f3f1-11e9-964d-63e771857eab.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-10-20 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-544320185
 
 
   > Could we not update the `host` column to include the port (like on the 
taskmanagers page) and link to the TaskManager page? Wouldn't this effectively 
work like the current iteration, just without an additional column?
   Like this:
   
![image](https://user-images.githubusercontent.com/3992588/67171376-6ccfd480-f3e9-11e9-9b33-cee77448cfa0.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-09-17 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-532091236
 
 
   #9696 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-09-05 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-528246002
 
 
   
![image](https://user-images.githubusercontent.com/3992588/64322504-4569a780-cff5-11e9-95da-b45f82151553.png)
   screenshot


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-09-04 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-527860492
 
 
   > This is rather unintuitive. The column key is "ID" but the values links to 
some log file.
   > We need a better column key, and imo shouldn't directly link to the log 
file but instead the page of the host TE.
   This is a part for log change, then user can easily see log from job. So add 
this log link. And I have discussed with till


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

2019-09-03 Thread GitBox
jinglining commented on issue #9601: [FLINK-13894][web]Web Ui add log url for 
subtask of vertex
URL: https://github.com/apache/flink/pull/9601#issuecomment-527712818
 
 
   
![image](https://user-images.githubusercontent.com/3992588/64221177-859a2e80-cefe-11e9-8fd4-ad70c1a54e65.png)
   
   
   > As usual, please include a screenshot of the changes.
   
   
![image](https://user-images.githubusercontent.com/3992588/64221195-8f239680-cefe-11e9-9830-395548f36d72.png)
   This is the screenshot of the changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services