lirui-apache commented on a change in pull request #10587: [FLINK-15269][table] Fix hive dialect limitation to overwrite and partition syntax URL: https://github.com/apache/flink/pull/10587#discussion_r358619173
########## File path: flink-table/flink-sql-parser/src/main/resources/org.apache.flink.sql.parser.utils/ParserResource.properties ########## @@ -17,6 +17,5 @@ # See wrapper class org.apache.calcite.runtime.CalciteResource. # MultipleWatermarksUnsupported=Multiple WATERMARK statements is not supported yet. -OverwriteIsOnlyAllowedForHive=OVERWRITE expression is only allowed for HIVE dialect. OverwriteIsOnlyUsedWithInsert=OVERWRITE expression is only used with INSERT statement. PartitionIsOnlyAllowedForHive=PARTITION expression is only allowed for HIVE dialect. Review comment: It seems incorrect that "PARTITION expression is only allowed for HIVE dialect", because with this PR, users can insert into/overwrite a partition w/o the Hive dialect. So we should change it to something like "Creating partitioned table is only allowed for HIVE dialect"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
