[GitHub] [flink] lirui-apache commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…
lirui-apache commented on a change in pull request #15155: URL: https://github.com/apache/flink/pull/15155#discussion_r612426937 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java ## @@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat Map properties = database.getProperties(); -boolean isGeneric = isGenericForCreate(properties); +properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true"); Review comment: I have updated the PR and we don't need to treat flink and hive databases differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…
lirui-apache commented on a change in pull request #15155: URL: https://github.com/apache/flink/pull/15155#discussion_r611298544 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java ## @@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat Map properties = database.getProperties(); -boolean isGeneric = isGenericForCreate(properties); +properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true"); Review comment: If the database properties don't have the `is_generic` key, it's considered generic by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
