[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-520307510 @bowenli86 Throwing `SqlExecutionException` is part of the contract of `Executor`, so in general I expect SQL client to be able to handle such exceptions. However, since each "call command" is implemented independently (regarding exception handling), I added a test anyway in `CliClientTest` to make sure the exception is indeed handled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-520201929 @bowenli86 The test in `LocalExecutorITCase` is to verify `LocalExecutor` throws a proper exception (i.e. `SqlExecutionException`) when db/catalog doesn't exist. Do you think we need a test for sql-client to make sure it doesn't crash? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-519797730 @bowenli86 PR updated according to your suggestions. Please take another look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-519767241 @xuefuz @bowenli86 @zjuwangg please have a look. I suppose it's trivial change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
