[GitHub] [flink] maosuhan commented on pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type
maosuhan commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1376836273 @laughingman7743 It looks all right now. @libenchao Do you have time to take another look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] maosuhan commented on pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type
maosuhan commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1375027529 @laughingman7743 The code LGTM. Would you also add documentation in protobuf page describing how to use timestamp type or other internal provided type? Some users may not know the corresponding flink type of Timestamp is a row structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] maosuhan commented on pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type
maosuhan commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1374837459 @laughingman7743 Thanks for your quick quick fix. We are almost there. Would you add another unit test like TimestampMultiRowToProto.java to make sure flink row can be correctly converted to protobuf object? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
