[GitHub] [flink] rmetzger commented on a change in pull request #12823: FLINK-18013: Refactor Hadoop utils to a single module

[GitBox]

rmetzger commented on a change in pull request #12823:
URL: https://github.com/apache/flink/pull/12823#discussion_r476240082



##
File path: flink-hadoop-utils/pom.xml
##
@@ -0,0 +1,78 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+   
+   flink-parent
+   org.apache.flink
+   1.12-SNAPSHOT
+   
+   4.0.0
+
+   flink-hadoop-utils
+
+   
+   
+   org.apache.hadoop
+   hadoop-common
+   ${hadoop.version}
+   provided
+   
+
+   
+   org.apache.hadoop
+   hadoop-hdfs
+   ${hadoop.version}
+   test
+   
+
+   
+   org.apache.flink
+   flink-core
+   ${project.version}
+   
+
+   
+   org.apache.flink
+   flink-test-utils-junit

Review comment:
   You are right, we can keep the dependency as you've declared it.
   It is defined as test-scoped in the parent pom's dependency management 
section.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] rmetzger commented on a change in pull request #12823: FLINK-18013: Refactor Hadoop utils to a single module

[GitBox]

rmetzger commented on a change in pull request #12823:
URL: https://github.com/apache/flink/pull/12823#discussion_r474752292



##
File path: flink-hadoop-utils/pom.xml
##
@@ -0,0 +1,78 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+   
+   flink-parent
+   org.apache.flink
+   1.12-SNAPSHOT
+   
+   4.0.0
+
+   flink-hadoop-utils
+
+   
+   
+   org.apache.hadoop
+   hadoop-common
+   ${hadoop.version}
+   provided
+   
+
+   
+   org.apache.hadoop
+   hadoop-hdfs
+   ${hadoop.version}
+   test
+   
+
+   
+   org.apache.flink
+   flink-core
+   ${project.version}
+   
+
+   
+   org.apache.flink
+   flink-test-utils-junit

Review comment:
   why is this not test scoped?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] rmetzger commented on a change in pull request #12823: FLINK-18013: Refactor Hadoop utils to a single module

[GitBox]

rmetzger commented on a change in pull request #12823:
URL: https://github.com/apache/flink/pull/12823#discussion_r457437875



##
File path: 
flink-hadoop-utils/src/main/java/org/apache/flink/hadoop/utils/HadoopUtils.java
##
@@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-package org.apache.flink.runtime.util;
+package org.apache.flink.hadoop.utils;
 
 import org.apache.flink.api.java.tuple.Tuple2;
 import org.apache.flink.configuration.ConfigConstants;

Review comment:
   Flink has already 3 `HadoopUtils`, this adds a forth one. 
   Maybe it makes sense to break this up into a "HadoopSecurityUtils", 
"HadoopConfigurationUtils" etc. ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org