[GitHub] [flink] roeyshemtov commented on pull request #11972: [FLINK-17058] Adding ProcessingTimeoutTrigger of nested triggers.

2020-05-22 Thread GitBox 


roeyshemtov commented on pull request #11972:
URL: https://github.com/apache/flink/pull/11972#issuecomment-632767977


   @aljoscha I personally don't like to use null (or at least wrap it with 
Objects.isNull), but i guess it is okay because the other Triggers use it too.
   You can merge this, thanks for help.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] roeyshemtov commented on pull request #11972: [FLINK-17058] Adding ProcessingTimeoutTrigger of nested triggers.

2020-05-18 Thread GitBox 


roeyshemtov commented on pull request #11972:
URL: https://github.com/apache/flink/pull/11972#issuecomment-630412268


   @aljoscha Fixed the CR comments, can u check?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] roeyshemtov commented on pull request #11972: [FLINK-17058] Adding ProcessingTimeoutTrigger of nested triggers.

2020-05-07 Thread GitBox 


roeyshemtov commented on pull request #11972:
URL: https://github.com/apache/flink/pull/11972#issuecomment-625394080


   @aljoscha thanks for helping on first contribution, added the license 
headers and fixed the CR changes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org