[GitHub] [flink] shuiqiangchen commented on pull request #13292: [FLINK-19097][python] Support add_jars() for Python StreamExecutionEnvironment.

2020-09-06 Thread GitBox 


shuiqiangchen commented on pull request #13292:
URL: https://github.com/apache/flink/pull/13292#issuecomment-687804784


   @dianfu Thank you for your comments, I have updated the PR according to your 
suggestions, please have a look.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13292: [FLINK-19097][python] Support add_jars() for Python StreamExecutionEnvironment.

2020-09-04 Thread GitBox 


shuiqiangchen commented on pull request #13292:
URL: https://github.com/apache/flink/pull/13292#issuecomment-686966367


   Hi @dianfu Thank you for your comments. Currently, users are not able to 
get/set Configurations for a StreamExecutionEnvironment since the 
StreamExecutionEnvironment.getConfiguration() is a protected method. So we 
choose to add these two new interface that the Java StreamExecutionEnvironment 
does not have, this is actually a bit controversial.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13292: [FLINK-19097][python] Support add_jars() for Python StreamExecutionEnvironment.

2020-09-01 Thread GitBox 


shuiqiangchen commented on pull request #13292:
URL: https://github.com/apache/flink/pull/13292#issuecomment-685244943


   Hi @HuangXingBo , thanks for your comments, I have updated the PR according 
to your suggestions, please have look at it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org