[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox 


shuiqiangchen commented on pull request #13756:
URL: https://github.com/apache/flink/pull/13756#issuecomment-717898835


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox 


shuiqiangchen commented on pull request #13756:
URL: https://github.com/apache/flink/pull/13756#issuecomment-717730700


   @anonymouscodeholic Thank you for pointing out the mistake， I have revised 
them in the latest commit.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-27 Thread GitBox 


shuiqiangchen commented on pull request #13756:
URL: https://github.com/apache/flink/pull/13756#issuecomment-717661702


   Hi @anonymouscodeholic ， I have updated the pr according to your 
suggestions, please have a look at it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-23 Thread GitBox 


shuiqiangchen commented on pull request #13756:
URL: https://github.com/apache/flink/pull/13756#issuecomment-715012391


   @anonymouscodeholic Sorry, I will add more comments for this test case to 
make it more intuitive.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-23 Thread GitBox 


shuiqiangchen commented on pull request #13756:
URL: https://github.com/apache/flink/pull/13756#issuecomment-714980749


   @anonymouscodeholic Thank you for your suggestions. Exactly, there is only 
the `testConfigurePythonExecution` need to be run as an IT. It would be better 
to split the tests in PythonProgramOptionsTest into two class (UTs and ITs) 
since UT has lower cost. 
   
   >After this PR it's not clear why does this test need to be an IT.
   
   The reason is that it requires to set a job jar to build a 
`PackagedProgram`, and the dummy job jar used in this test case is built in the 
packing phase.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org