[GitHub] [flink] sjwiesman commented on pull request #13384: [FLINK-19224][state-processor-api] Support reading window operator state

2020-09-17 Thread GitBox


sjwiesman commented on pull request #13384:
URL: https://github.com/apache/flink/pull/13384#issuecomment-694269698


   @alpinegizmo 
   
   > trigger state isn't supported -- so any CountTrigger or custom Trigger 
with state can't be read
   
   Yes, I will update the docs
   
   > window state cannot be written, so I can't use this to migrate between 
state backends
   
   I have this ready to go. I just wanted go get this one merged in first. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] sjwiesman commented on pull request #13384: [FLINK-19224][state-processor-api] Support reading window operator state

2020-09-16 Thread GitBox


sjwiesman commented on pull request #13384:
URL: https://github.com/apache/flink/pull/13384#issuecomment-693541955


   @alpinegizmo thank you for looking. I've tried to address all your comments. 
In particular, I spent time on a better docs example that I hope answers most 
of your questions. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] sjwiesman commented on pull request #13384: [FLINK-19224][state-processor-api] Support reading window operator state

2020-09-14 Thread GitBox


sjwiesman commented on pull request #13384:
URL: https://github.com/apache/flink/pull/13384#issuecomment-692328179


   @alpinegizmo would you like to take a look at this. This PR is mostly 
boilerplate to support all the different window operator configurations. All 
the actual runtime changes have already been merged in. In particular, if you 
want to look at the docs and the interfaces in the `api` package. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org