xuefuz commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken
URL: https://github.com/apache/flink/pull/8610#issuecomment-498782835
> I wonder that, since`moveToTrash()` is mainly a util, should we move it to
a separate util shim class like `HiveUtilShim`? The current `HiveShim` class,
as its javadoc says, is mainly for Hive Metastore. We probably should rename it
to `HiveClientShim`?
>
> LGTM otherwise.
HiveShim is quite generic in naming. It's a shim, so in theory anything can
be put there. Maybe we just need to update the javadoc to reflect the new
addition.
Having another shim for utils might be an overkill for now. However, we can
keep an eye on this and see how we organize better when this layer gets too
heavy.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
