[GitHub] [flink] xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve…
xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve… URL: https://github.com/apache/flink/pull/9524#issuecomment-525077757 > LGTM. W.r.t testing, shall we at least add build profiles for these newly added Hive versions in flink-connector-hive's pom so they can currently be run manually? > > E.g. > > ``` > >hive-1.2.0 > >1.2.0 > 2.6.5 >3.2.1 > > >... > ``` > > I created [FLINK-13866](https://issues.apache.org/jira/browse/FLINK-13866) to track the testing plan. Let's discuss about this in the JIRA you created. For short comment, I don't think we need to provide a profile for each version we support. There are just too many of them. However, this and how to test in general can be discussed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve…
xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve… URL: https://github.com/apache/flink/pull/9524#issuecomment-524974073 PR updated based on review feedback. @bowenli86 could you take another look? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve…
xuefuz commented on issue #9524: [FLINK-13841][hive] Extend Hive version support to all 1.2 and 2.3 ve… URL: https://github.com/apache/flink/pull/9524#issuecomment-524485653 cc @bowenli86 @lirui-apache @zjuwangg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
