[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1546911786 @XComp 感谢您的review,我已经完成了修改. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1519451823 @XComp If you have time, please come and have a look again, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1437989291 @XComp The problem of safeDivide has been modified. Could you please help me review it? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1437722395 > How come we're not touching the `safeDivide` method, which you mentioned in the [corresponding Jira issue comment](https://issues.apache.org/jira/browse/FLINK-31084?focusedCommentId=17690426=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17690426)? I see that you did not reply to me, so I did not modify this method. Now I will correct this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1436625887 @XComp Can you take a look? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
