[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-481080653 @pnowojski Thanks for pointing these version number. I have upgraded them to `2.2.0` except : `flink-filesystems/flink-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE:Azure Data Lake Store - Java client SDK 2.0.11`. Moreover, I found the first arg `KAFKA_CONNECTOR_VERSION` in `test_sql_client_kafka_common.sh` seems useless. I suggest that we should remove them in another PR in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-477660105 @eliaslevy Thanks for your suggestion, accepted your opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-477611434 @eliaslevy Sounds reasonable. My change will make the users confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-477545456 @aljoscha OK, thanks for your reply. I will remark the kafka client version in the document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-477522713 @eliaslevy Your comment makes sense. I agree with you. I suggest we should describe the current kafka client version which the universal kafka connector tracks in the documentation. Any time when we upgrade the kafka's version, we also should update the document. What do you think? @pnowojski @aljoscha @zentol This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0
yanghua commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-476986958 cc @aljoscha and @pnowojski This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
