[GitHub] [flink] zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox 
zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated 
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-500345324
 
 
   Thanks for the updates @azagrebin .
   I left some final nit comments relevant with new introduced context.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-06 Thread GitBox 
zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated 
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-499403469
 
 
   Thanks for the updates @azagrebin ! 
   I like the way of metric factory to make `NetworkEnvironment` simple. Only 
several nit comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-05 Thread GitBox 
zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated 
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-499340499
 
 
   @azagrebin thanks for the updates and I left some other small comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-05-27 Thread GitBox 
zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated 
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-496231763
 
 
   Thanks for the replies @zentol .
   
   But in this PR `parentGroup.addGroup("Network")` is called twice in 
`NetworkEnvironment#createResultPartitionWriters/InputGates`. So we should 
change to create it still in task class and then pass it into 
`createResultPartitionWriters/InputGates` separately?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services