zhijiangW commented on issue #9477: [FLINK-13765][task] Introduce the InputSelectionHandler for selecting next input in StreamTwoInputSelectableProcessor URL: https://github.com/apache/flink/pull/9477#issuecomment-524481057 Thanks for this review @pnowojski ! Actually this PR would not be a blocker for the following work as I misleading before. If just from the design aspect, the benefits might not be very obvious as you mentioned. My previous thought: - We could make `StreamTwoInputSelectableProcessor` a bit thin after refactoring, because we remove two non-final vars and two methods from the processor. - In previous way, `StreamTwoInputSelectableProcessor` would involve in three fields {InputSelectable, InputSelection, availableInputsMask} to expose too many details. After refactoring, the processor only interacts with one component and some details are hidden behind. I could understand your concern and it would be better if we could further reduce some complex interactive logics provided by `TwoInputSelectionHandler`. So I think this pr can be pending now, and after we find something very confirmable to be done, we can merge then.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
