[GitHub] [flink] zhuxiaoshang commented on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-09-14 Thread GitBox


zhuxiaoshang commented on pull request #13225:
URL: https://github.com/apache/flink/pull/13225#issuecomment-692442654


   > @zhuxiaoshang thanks for your contribution, left some comments based on 
the item `5. 中文标点符号` of 
[Flink+Translation+Specifications](https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)
 please let me know what do you think ,thanks.
   
   yes,you are right,brackets should be chinese form.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] zhuxiaoshang commented on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-31 Thread GitBox


zhuxiaoshang commented on pull request #13225:
URL: https://github.com/apache/flink/pull/13225#issuecomment-683767507


   > @zhuxiaoshang thanks for your contribution, left some comments, please let 
me know what do you think, thanks.
   
   thanks for your review,i had fixed accroading to your suggestions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] zhuxiaoshang commented on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox


zhuxiaoshang commented on pull request #13225:
URL: https://github.com/apache/flink/pull/13225#issuecomment-680556966


   Thanks for your review @RocMarshal.I have made some changes according to 
your suggestions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org