[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1722311553 Guys, I wrote a bunch of tests heavily inspired by https://github.com/apache/flink-connector-opensearch/pull/5 since they have very similar implementations. Thanks @reta for sharing, it helped a lot! I need to create the documentation and would appreciate some guidance on how to generate that. I'm looking forward to your feedback :) cc @MartijnVisser @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1690822793 > What's the progress of this? Hi @reswqa, thanks for asking. I'm writing the retry mechanism inspired by the PR that @reta shared here. After that, I'll write tests and mark the PR as ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1579604638
> I try to compile your code, but throwing follow errors:
>
> ```
> [INFO] There are 69 errors reported by Checkstyle 8.14 with
/tools/maven/checkstyle.xml ruleset.
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/OperationSerializer.java:[33]
(javadoc) JavadocType: 缺少 Javadoc 。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java:[26]
(imports) AvoidStarImport: 不应使用 '.*' 形式的导入 - java.io.* 。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java:[29]
(javadoc) JavadocType: 缺少 Javadoc 。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java:[53]
(blocks) NeedBraces: 'if' 结构必须使用大括号 '{}'。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java:[54]
(blocks) NeedBraces: 'if' 结构必须使用大括号 '{}'。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/INetworkConfigFactory.java:[21]
(whitespace) EmptyLineSeparator: 'package 前应有空行。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/INetworkConfigFactory.java:[27]
(javadoc) JavadocType: 缺少 Javadoc 。
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Writer.java:[32]
(imports) ImportOrder: Import org.apache.flink.api.connector.sink2.Sink
appears after other imports that it should precede
> [ERROR]
src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Writer.java:[35]
(imports) ImportOrder: 导入组之前的额外空行
'org.apache.flink.connector.base.sink.writer.BufferedRequestState'。
> ```
@StefanXiepj I'll fix these Checkstyle errors, and once I do, I'll let you
know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1579602598 > > Even though I'm concerned about the implementation using Kryo, I'll mark it as ready to review and get your feedback. > > @reta Could you help with a review? @reta thank you for the review. I appreciate that. I'm going to work on what you pointed out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
