[GitHub] dawidwys commented on issue #6511: [FLINK-10085][tests] Update AbstractOperatorRestoreTestBase for 1.5

2018-08-13 Thread GitBox
dawidwys commented on issue #6511: [FLINK-10085][tests] Update 
AbstractOperatorRestoreTestBase for 1.5
URL: https://github.com/apache/flink/pull/6511#issuecomment-412500769
 
 
   Are the savepoints binary deterministic? I've tried to generate savepoints 
twice and each time I got different contents (also compared with savepoint in 
this PR). If it should be deterministic I will try to repeat it once again. 
Maybe I've done sth completely wrong.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dawidwys commented on issue #6511: [FLINK-10085][tests] Update AbstractOperatorRestoreTestBase for 1.5

2018-08-09 Thread GitBox
dawidwys commented on issue #6511: [FLINK-10085][tests] Update 
AbstractOperatorRestoreTestBase for 1.5
URL: https://github.com/apache/flink/pull/6511#issuecomment-411749740
 
 
   Do we have any reasonable way to verify those kinds of PRs? Or shall we just 
look for typos while reviewing it? 
   
   If the latter than +1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services