[GitHub] dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-447756558 @sunjincheng121 Thanks a lot for the kind remind. Have updated the PR adding harness test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-444376385 @walterddr Thanks a lot for your comments. Please take a look at if my reply makes sense to you. Thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-443967089 @sunjincheng121 @walterddr Got your points and make sense to me. Have updated the PR to address your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-443625031 The statement `env.setStateBackend(getStateBackend)` at the beginning of the `AggregateITCase. testDoubleGroupAggregation` can make sure RocksDBStatebackend is used. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
dianfu commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-443566996 Hi @walterddr ， thanks a lot for your review. Make sense to me and have added an IT case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
