[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/1690 I left a few thoughts in the corresponding JIRA issue: https://issues.apache.org/jira/browse/FLINK-3398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/1690 @shikhar Ok, sure no problem :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user shikhar commented on the issue: https://github.com/apache/flink/pull/1690 @tzulitai sorry I meant I won't be able to get to this change at all, so anyone please feel free to take this up! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/1690 @shikhar Sure, please feel free to tag me for a review once you are done. I think you'll need to manually close this PR yourself, you can close it when the new PR is opened. Another option is to rebase this PR on the current master, and after you finish shaping up again, force push to this same PR branch. Also, since this will be affecting how users interact with the Kafka consumer, let's wait until we get consensus from @StephanEwen and @rmetzger on the proposed change before you get on to working on it ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user shikhar commented on the issue: https://github.com/apache/flink/pull/1690 Thanks @tzulitai! I like your proposal, I'm afraid I won't be able to get around to shaping up this PR though so might be best to start a new one (please feel free to close). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1690: FLINK-3398: Allow for opting-out from Kafka offset auto-c...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/1690 What's the status of this PR? I think it is a good functionality to add. @shikhar if you'd like to continue working on this, I'm happy to help shepherd this PR for merging. Some of my input from the previous discussions on the interpretation of "auto.commit.enable": I agree with @rmetzger that stretching the definition of this config to "on checkpoint or periodically" isn't a good idea. Committing the offsets back to Kafka on 'notifyCheckpointComplete()' is a Flink-specific behaviour. I think mixing Flink-specific behaviour within Kafka original configs can be confusing for frequent Kafka users and difficult to maintain in the long run. Perhaps we can have something like "flink.commit-on-checkpoint". What I have in mind: > // commit to ZK / broker only on Flink's checkpoint. > flink.commit-on-checkpoint=true auto.commit.enable=* > > // periodically commits to ZK / broker > flink.commit-on-checkpoint=false auto.commit.enable=true > > // no commit to ZK / broker at all > flink.commit-on-checkpoint=false auto.commit.enable=false The first option will be valid only when checkpointing is enabled also. Otherwise, whether or not checkpointing is enabled does not effect the above settings. I think this better matches the idea that "the Kafka offset store is only used for exposure of progress to the outside world, and not for recovery / manipulation of how Flink reads from Kafka". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
