[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 @jagatfx Yes, this is still in my TODO list, I have not had a lot of time to follow the process to make an image official, but I hope I will in the next days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user jagatfx commented on the issue: https://github.com/apache/flink/pull/2240 @iemejia Were you able to followup on creating the official docker image. It's a great idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 Ok, I will check how is the procedure and I will tell you if we need something else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2240 Yes, that would probably be good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 About the flink image version, we can support multiple versions via tags, those are pulled with the: separator, e.g. docker pull flink:1.0.3-hadoop26-scala_2.10 And we can agree on a default (e.g. most recent versions which would be -> :latest). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 Great, closing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2240 I merged it. Could you please close this PR if it doesn't close automatically. Thanks for the work! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2240 Would the Flink image be tied to a specific Flink version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 One last thing, are you interested on getting the flink image into becoming an official docker image ? I took a look around it and it seems we can ask for this. The benefit is that users can just make 'docker pull flink' and get the flink image from the hub.docker.com repository ready to use (e.g. I am publishing for the moment my own 'unofficial' builds at https://hub.docker.com/r/iemejia/flink/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 Yes, it is done, I am really happy of getting rid of python/supervisord in the image now. Please merge if you consider it ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2240 @iemejia This is now good to merge? From my side it looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2240 I added this last commit to remove the dependency on supervisord, thanks to @greghogan for the 'wait' idea. Now flink has the thinnest docker image possible :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
