[GitHub] flink issue #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL and Strea...

2016-08-02 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/2274
  
Thanks @wuchong. I will add some additional comments/formatting and merge 
it...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL and Strea...

2016-07-24 Thread nssalian
Github user nssalian commented on the issue:

https://github.com/apache/flink/pull/2274
  
LGTM after the nits. But I would request someone else have a pass over it 
before moving forward since I am new to the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL and Strea...

2016-07-24 Thread wuchong
Github user wuchong commented on the issue:

https://github.com/apache/flink/pull/2274
  
@smarthi  Thanks for reviewing. I have addressed the typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---