[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 Please don't spend your time to write an actual test for this; for this change it is not necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user aditivin commented on the issue: https://github.com/apache/flink/pull/2307 Thanks @nssalian , @zentol - I'll keep the points in mind for next time. I will try testing the logging and update this thread. Also, I've enabled travis in my repository :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 +1 to merge. Just for future considerations: The Flink community uses rebasing instead of merging branches to avoid these pesky merge commits. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2307 Hi @aditivin , welcome to the community. Thank you for the PR as well. A few suggestions: 1) Upon opening a PR, it is best to add more information regarding testing or even checks that you have done. I believe the PR template helps add more information with regards to testing /checks. 2) I don't see much testing that can be done here, anything you see that can help testing the debug logging, @aditivin? 3) One additional point would be to enable the travis build on your repository. (As Flink comes with a travis.yml all you need to do is to go to Travis, login with your github user and hit enable on the repo.) A local build helps understand if there are issues that could occur. This link should be helpful: https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
