[GitHub] flink issue #2422: FLINK-4499: Introduce findbugs maven plugin
Github user smarthi commented on the issue: https://github.com/apache/flink/pull/2422 I updated the findbugs-exclude.xml with some basic rules that can be ignored. I set the to 'default' for now - can't keep it 'High' since it was freezing up my laptop. There are still more rules that can be excluded, but I think this is a good start to seed the excluded rules. Build times take an impact if the is set to high, I now have that set to 'default'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2422: FLINK-4499: Introduce findbugs maven plugin
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2422 Thanks for adding this. I think that pure warning by the plugin will not be read and respected really. So it makes only sense when a "bug" detected by the plugin fails the build. How about starting with a low set of settings and configuring it to fail when detecting errors? We can then gradually activate more and more visitors. Also, do you have any experience in how finbugs usually affects the build times? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2422: FLINK-4499: Introduce findbugs maven plugin
Github user smarthi commented on the issue: https://github.com/apache/flink/pull/2422 Setup a default findbugs-exclude.xml, please feel free to customize as u deem fit for Flink. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
