[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 Hi @uce, I've rebased changes and updated the UI according to your suggestion. Now it looks like: https://cloud.githubusercontent.com/assets/592286/22408112/2165724a-e66b-11e6-8008-6042a97ea412.png";> What do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 Hi @uce Thank you for your review. I'll update the UI in the next couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2448 It worked well, but I'm a little hesitant to merge it as it is. Running with higher parallelism than 1 I think that the button is pretty invasive:  Can we make this a little less eye-catching? Maybe just a link next to the attempt number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 @rmetzger @iampeter I've rebased the code and updated it according to your suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2448 Okay, I'll run gulp when merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2448 @rmetzger will you be merging? if so, `flink-runtime-web/web-dashboard/web/js/index.js` just needs a `gulp` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2448 @mushketyk could you try `npm view gulp-stylus` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2448 Good to go from my side. @rmetzger and @iampeter - since you are working on the web UI currently, can you try and merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 Is there anything else that should be updated in this PR? It has been in review for more than a month. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 @StephanEwen Should I change anything else in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 @StephanEwen I've renamed the class as you suggested. Regarding the CSS change, I don't know why these changes are added. I have the required (according to README.md) `gulp` version: ``` > $ gulp -version [21:06:35] CLI version 3.9.1 [21:06:35] Local version 3.9.1 ``` I wonder if a `.styl` file was changed in one of the previous commits but it was not compiled to `.css`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2448 Thank you for the review @StephanEwen I'll update the PR in the evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2448 Good change, all in all, good work! Few minor comments, otherwise +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
