[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2452 @liuyuzhong Because we proceed with #2439 , can you close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 That's OK. I understand. It's not so easy to make a decesion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2452 Agreed, let's proceed with #2439. Sorry for the back and forth, but these things are important to discuss so that everyone is on board and we make a good decision. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 OK, how about reopen pull requests #2439 ? Just update storm version to 1.0, and it can support storm 1.0+ version program. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2452 Sorry for chiming in late. Left some comments on the ML thread. Overall I think it's ok to switch focus on supporting 1.0+ Storm versions only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2452 There is not a lot of response on the mailing list. Apparently switching to the newer Storm version does not bother anyone. My guess would be to switch to Strom 1.0+ and remove the storm 0.8/0.9 code. What do others think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 @mxm OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2452 @liuyuzhong Let's wait a couple more days for the community to respond. You don't have to close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 @mxm Yes, all of this code are copy from old code adapted to Strom 1.0.0. So we close this pull request and wait for decision? Actually, I was submit a pull request for old code adpate to storm version to 1.0.0. https://github.com/apache/flink/pull/2439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2452 It looks like this is basically a copy of the old code adapted to the Storm 1.0.0 dependency. This would duplicate a lot of code. I've started a thread on the mailing list, whether we want to add a new module for Storm 1.0.0 or stop supporting old Storm versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2452 I think you ran out of memory. Travis CI build passed, so the PR's testing state seems to be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 Jenkins run error: ``` Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.585 sec - in org.apache.flink.test.recovery.TaskManagerProcessFailureStreamingRecoveryITCase Running org.apache.flink.test.checkpointing.UdfStreamOperatorCheckpointingITCase Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.442 sec - in org.apache.flink.test.recovery.FastFailuresITCase Running org.apache.flink.test.checkpointing.RescalingITCase ERROR: Maven JVM terminated unexpectedly with exit code 137 Putting comment on the pull request Finished: FAILURE ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 Test Result (失败) ``` org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should detect a failing task manager org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should handle gracefully failing task manager org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should handle hard failing task manager org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should go into a clean state in case of a TaskManager failure org.apache.flink.test.cancelling.MapCancelingITCase.testSlowMapCancelling org.apache.flink.test.cancelling.MapCancelingITCase.testMapCancelling org.apache.flink.test.cancelling.MapCancelingITCase.testMapPriorToFirstRecordReading org.apache.flink.test.cancelling.MapCancelingITCase.testMapWithLongCancellingResponse org.apache.flink.test.checkpointing.CoStreamCheckpointingITCase.org.apache.flink.test.checkpointing.CoStreamCheckpointingITCase org.apache.flink.test.checkpointing.EventTimeAllWindowCheckpointingITCase.org.apache.flink.test.checkpointing.EventTimeAllWindowCheckpointingITCase org.apache.flink.test.checkpointing.SavepointITCase.testTriggerSavepointAndResume org.apache.flink.test.checkpointing.SavepointITCase.testCheckpointsRemovedWithJobManagerBackendOnShutdown org.apache.flink.test.classloading.ClassLoaderITCase.testDisposeSavepointWithCustomKvState org.apache.flink.test.exampleScalaPrograms.WordCountITCase.testJobWithoutObjectReuse org.apache.flink.test.exampleScalaPrograms.WordCountITCase.testJobWithObjectReuse org.apache.flink.test.failingPrograms.JobSubmissionFailsITCase.org.apache.flink.test.failingPrograms.JobSubmissionFailsITCase org.apache.flink.test.recovery.TaskManagerProcessFailureBatchRecoveryITCase.testTaskManagerProcessFailure[0] org.apache.flink.test.web.WebFrontendITCase.org.apache.flink.test.web.WebFrontendITCase ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 build success ``` [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:28 h [INFO] Finished at: 2016-09-05T04:07:42+00:00 [INFO] Final Memory: 195M/581M ``` but Finished: UNSTABLE ``` [JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-contrib/flink-streaming-contrib/target/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar to org.apache.flink/flink-streaming-contrib_2.10/1.2-SNAPSHOT/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar channel stopped Putting comment on the pull request Finished: UNSTABLE ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2452 @liuyuzhong Try rebasing on the latest master, should be fixed with https://issues.apache.org/jira/browse/FLINK-4570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2452 @liuyuzhong Should be caused by bumping the Scalastyle version from 0.5.0 to 0.8.0. Doesn't occur on my machine though :( Investigating. Probably lowering the Scalastyle version again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
