[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2454 Thanks @wuchong. Will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2454 It seems that Calcite is planning to add additional clauses to the SQL statement. Like `SELECT STREAM x FROM y EMIT xyz`. If we really remove the keyword we have to make sure that Calcite's parser will also parse `EMIT` without the `STREAM` keyword. @fhueske what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2454 Hi @fhueske @twalthr , do you have time to have a look again? Any advices are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2454 Hi @fhueske , thanks for reviewing, I updated this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2454 Hi @wuchong, thanks for the PR. Just had two minor comments. Thanks, Fabian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2454 Thank @wuchong. Looks good to merge. @fhueske do you also want to have a look at it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
