[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2457 Merging this ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2457 Would be cool if we could also merge this to `release-1.1` if it is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2457 @iampeter @greghogan I've update the PR according to your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2457 @greghogan right - missed the generated files. @mushketyk I suppose `gulp`ing will help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2457 1) `JsonPlanGenerator.java:55` should be reverted to use `NOT_SET`. 2) `index.js` is changing jobServer from the empty string to 'http://localhost:8081/'. 3) `vendor.js` is upgrading the version of `imagesLoaded` from 4.1.0 to 4.1.1. In the past we have specified in `flink-runtime-web/web-dashboard/bower.json` to not upgrade point releases since the changes were obfuscating the remainder of the pull request. I have not noticed if we have subsequently followed up with a PR to upgrade the libraries. We may be at a good point in the 1.2 release cycle to do this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2457 @mushketyk from my side looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2457 Hi @iampeter I've updated the PR according to you suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2457 Hi @greghogan I've fixed the code according to your suggestion. Could you give it another look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2457 @iampeter Did you have a chance to take a look at this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
