[GitHub] flink issue #2662: [FLINK-4824] [client] CliFrontend shows misleading error ...

[greghogan]

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/2662
  
@mxm thanks for the review. I added a second commit which I think satisfies 
your request. When no job is executed then the message is printed to stderr 
without a stacktrace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2662: [FLINK-4824] [client] CliFrontend shows misleading error ...

[mxm]

Github user mxm commented on the issue:

https://github.com/apache/flink/pull/2662
  
Thanks for the PR @greghogan! Having a custom exception for missing 
arguments to a user program is a good approach. However, it requires the author 
of the program to use the custom exception. At least, we would have to adapt 
all the included examples. Additionally, it would be nice to throw another 
custom exception when no Flink job was generated during execution of the jar 
(which might be because of missing arguments). Currently, we simply throw a 
`ProgramInvocationException` which could look like a serious error to the user 
when merely arguments are missing. 

So +1 but we might do some follow-ups to fully solve the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---