[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2670 +1 and thanks for the benchmarking link! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2670 I pushed a commit to remove the `GraphMetrics` example. I think providing drivers for all library methods is both desirable and ambitious. If we like the form and functionality of the current drivers then I'd like to look at consolidating common functionality where possible. We may also be able to put multiple similar algorithms like `JaccardIndex` / `AdamicAdar` / `CommonNeighbors` into the same driver. I had first removed `TriangleListing` as it's not an algorithm but I added it back due to Facebook's recent benchmarking: https://code.facebook.com/posts/319004238457019/a-comparison-of-state-of-the-art-graph-processing-systems --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2670 Hi @greghogan, I really like the cleanup and new organization! Two thoughts: - is the plan to add drivers for all library methods? - shall we remove the `GraphMetrics` example since there is a better driver? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
