[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2758 The PR looks good. The only thing missing is documentation. I will add it and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 Great ! The PR looks good to me now, thank you for your contribution ! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 @wuchong sure, fixed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 The Travis CI has failed because of `BuiltInMethods` line length, could you fix this ? ``` [INFO] --- scalastyle-maven-plugin:0.8.0:check (default) @ flink-table_2.10 --- error file=/home/travis/build/apache/flink/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/BuiltInMethods.scala message=File line length exceeds 100 characters line=35 error file=/home/travis/build/apache/flink/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/BuiltInMethods.scala message=File line length exceeds 100 characters line=36 Saving to outputFile=/home/travis/build/apache/flink/flink-libraries/flink-table/target/scalastyle-output.xml Processed 229 file(s) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 Hi @wuchong, I have resolved the conficts :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 It would be great if you can rebase your branch and resolve the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 Hi @wuchong , I have modified the test cases according to your comments, please review my latest commit. Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
