[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2767 I closed the PR manually using another commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2767 Hi @mikedias! Your contribution has been merged with 8699b03d79a441ca33d9f62b96490d29a0efaf44 and b5caaef82add4a6f424094d526700c77b011724e. Could you manually close this PR? The bot only closed the new restructure PR. Thanks a lot for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2767 Sounds good. Thank you for taking care of this @tzulitai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 @tzulitai sure, no problem! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2767 @mikedias @rmetzger @StephanEwen I've also responded to the discussion in the ML started by Robert with a +1. A recap of the proposed approach on how we proceed: since the ES connectors share a lot of code, we'll refactor the ES connectors by having a `flink-connector-elasticsearch-base` module, and let version specific connections stem from that; basically how we're currently maintaining the Kafka connectors. There are two +1 votes for this approach, and no other objections, so I think we can agree on proceeding. @mikedias, are you be ok with me using your PR as a base to refactor the ES connectors? I'll open a new PR with your changes and mine together. I'll also let you know when the PR is opened :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 I have no problem in hosting the connector in my github account. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2767 @StephanEwen I'll start a discussion on the mailing list to decide how we want to proceed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2767 @mikedias @rmetzger How do we proceed with this pull request? Should it become part of Flink, Bahir, or should hosted in the contributor's repository? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2767 If you cannot exclude the netty dependency, you could try to shade it away: https://maven.apache.org/plugins/maven-shade-plugin/ We do this all the time for conflicting dependencies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 Not sure if I can exclude netty4 dependency, but I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 No, ES is not backward compatible... But we can reuse some classes or interfaces between versions. I have plans to do this in another PR, just for isolate possible issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2767 From taking a quick look at it, I would suggest that this connector shades netty away. That way we can avoid conflicts whenever we adjust Flink's internal netty version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2767 Is elastic search backwards compatible? Is there a way to support multiple Elasticsearch versions in one connector? Would be nice not having to maintain three different versions of the ElasticSearch connector. @rmetzger What is your take on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
