[GitHub] flink issue #2845: [FLINK-5096] Make the RollingSink rescalable.
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2845 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2845: [FLINK-5096] Make the RollingSink rescalable.
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2845 Great, will start merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2845: [FLINK-5096] Make the RollingSink rescalable.
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2845 Hi @zentol ! Thanks for the review. I integrated the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2845: [FLINK-5096] Make the RollingSink rescalable.
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2845 Just 2 more comments; i can also fix them while merging if you agree with them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2845: [FLINK-5096] Make the RollingSink rescalable.
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2845 Thanks for the review @zentol ! I integrated your comments and rebased to the master. Let's see what travis has to say and then merge it if you have no further comments ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
