[GitHub] flink issue #2920: [FLINK-5218] [state backends] Eagerly close checkpoint st...

2016-12-02 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2920
  
Manually merged in cc006ff18cc7032de3be3fdd9ef7ad383e88bba0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2920: [FLINK-5218] [state backends] Eagerly close checkpoint st...

2016-12-02 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2920
  
Thanks for the review, merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2920: [FLINK-5218] [state backends] Eagerly close checkpoint st...

2016-12-02 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/2920
  
I think the changed semantics makes actually more sense. It should also be 
fine for all callers, as returning null to them was also previously possible 
and IRC there should be no special meaning to an empty handle in 1.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2920: [FLINK-5218] [state backends] Eagerly close checkpoint st...

2016-12-01 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2920
  
@StefanRRichter There is one change of semantics that would be good to get 
your input on: A checkpoint stream to which a `byte[0]` array was written is 
now actually empty and returns a `null` state handle in the same way as if 
nothing was ever written. Before this change, it would have created a state of 
zero bytes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---