[GitHub] flink issue #2924: [FLINK-5229] [tm] Discard completed checkpoints if a subs...

2016-12-02 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/2924
  
Thanks for testing it @uce and @StephanEwen. Really good finding with the 
bug. I'll fix it and then I will merge the branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2924: [FLINK-5229] [tm] Discard completed checkpoints if a subs...

2016-12-02 Thread uce
Github user uce commented on the issue:

https://github.com/apache/flink/pull/2924
  
Tested this with a job that fails during checkpointing and it works like a 
charm for both chained and non chained state, but I found another issue with 
discarding pending checkpoints. The task states map is cleared although it is 
given the async discarder. +1 to fix this related issue and merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---