[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2968 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2968 Just noticed that the row comparator and serializer tests should be moved to `org.apache.flink.api.java.typeutils.runtime`. I will do that before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2968 @fhueske Yes. I already started https://github.com/tonycox/flink/tree/FLINK-5188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2968 Hi @fhueske , thanks for reviewing. I have addressed the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2968 @tonycox @wuchong Yes, we can move `RowCsvInputFormat` in FLINK-5188. But that issue should also be included in the 1.2 release. @tonycox, can you start with FLINK-5188 and base it on the changes of this PR? We should try to get this done as soon as possible. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2968 Hi @tonycox , I agree we should move `RowCsvInputFormat` also. But I think it would be better to do that in another JIRA like FLINK-5188. Let's keep this PR simple so that it can be in before 1.2 release . What do you think ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2968 Hi @wuchong, maybe we should move `RowCsvInputFormat` also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2968 Hi @tonycox , thanks for your reviewing. I addressed some of your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2968 Thanks for working on this @wuchong. I will review this next week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
