[GitHub] flink issue #3086: Improve docker setup
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3086 No, looks good. Thanks. As Greg mentioned, please open a JIRA issue next time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3086: Improve docker setup
Github user kaelumania commented on the issue: https://github.com/apache/flink/pull/3086 @mxm thanks :) needs there anything to be done, until this PR can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3086: Improve docker setup
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn neither `docker build` nor `docker compose build` support setting
environment variables from outside during the build. Further as the
`docker-compose` documentation states
> Note: If your service specifies a build option, variables defined in
environment will not be automatically visible during the build. Use the args
sub-option of build to define build-time environment variables.
It is only possible to give arguments to the build step of `docker-compose`
using the `--build-args` option, which can be interpolated with
`${my_env_var}`. But still requires the `Dockerfile` to use `ARG`.
Further I question the Docker version compatibility. First, flink could
provide an automated build on Docker Hub. Second, one could provide a
`Dockerfile.legacy` aswell.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3086: Improve docker setup
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3086 @kaelumania `ARG` is only available from Docker 1.10 on and upwards. I believe docker-compose also offers to configure environment variables either through the compose file or via a command-line argument. If we refrained from `ARG`, we could keep backwards-compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3086: Improve docker setup
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn One drawback using `ENV` might be with docker-compose, see
https://docs.docker.com/compose/compose-file/#/args which states
> You can omit the value when specifying a build argument, in which case
its value at build time is the value in the environment where Compose is
running.
> Note: If your service specifies a build option, variables defined in
environment will not be automatically visible during the build. Use the args
sub-option of build to define build-time environment variables.
On the other hand the Dockerfile reference says
(https://docs.docker.com/engine/reference/builder/#/arg)
> Unlike an ARG instruction, ENV values are always persisted in the built
image.
Maybe something like this can be used to support both
```
1 FROM ubuntu
2 ARG CONT_IMG_VER
3 ENV CONT_IMG_VER ${CONT_IMG_VER:-v1.0.0}
4 RUN echo $CONT_IMG_VER
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3086: Improve docker setup
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3086 For creating tickets, it's actually a requirement from Apache Legal as PR comments are then automatically added to the associated Jira which documents the contribution of the code to the project. The build is sufficiently passing. Several of the tests are unstable on TravisCI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3086: Improve docker setup
Github user kaelumania commented on the issue: https://github.com/apache/flink/pull/3086 I am not sure, why the build fails as I am not deeply familiar with the Java/Scala world. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3086: Improve docker setup
Github user kaelumania commented on the issue: https://github.com/apache/flink/pull/3086 @greghogan No, I didn't create a Ticket (sorry, I was not sure if this change justifies a Ticket). But I would love to see a Ticket about an automated build at DockerHub for Flink. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
