[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs

2017-01-13 Thread senorcarbone
Github user senorcarbone commented on the issue:

https://github.com/apache/flink/pull/3088
  
Hey! In this upcoming [PR ](https://github.com/apache/flink/pull/1668) 
there is a custom operator responsible for the logging at the iteration head. 
Hope this does not break your tests in case they assume a null op.
Also, in case any of you is familiar with asynchronous checkpoints with 
ListState, could you check my last question in the same PR? thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs

2017-01-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/3088
  
Thanks for reviewing and merging @aljoscha !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs

2017-01-13 Thread aljoscha
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3088
  
Merged, could you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs

2017-01-12 Thread aljoscha
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3088
  
Changes look very good! I fixed the formatting of the newly added methods 
in `TestingCluster` to conform to Scala coding guidelines.

I rebased on master, will wait for Travis to give the green light and then 
merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs

2017-01-10 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/3088
  
cc @aljoscha 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---