[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...

2017-01-13 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3090
  
looks good to me, adding it to my next batch,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...

2017-01-13 Thread aljoscha
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3090
  
@zentol do you want to recheck and merge if good?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...

2017-01-13 Thread ymarzougui
Github user ymarzougui commented on the issue:

https://github.com/apache/flink/pull/3090
  
@aljoscha Added a test and changed Path type according to @zentol's 
suugestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...

2017-01-12 Thread aljoscha
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3090
  
The changes look very good! I think it would be good to add a test for 
nested reading in `ContinuousFileProcessingTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---