[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user uce commented on the issue: https://github.com/apache/flink/pull/3093 Thanks! LGTM, going to merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @sachingoel0101 PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 Please retest! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol thanks and yes I verified the expected behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3093 That looks better. I tried out these changes locally and they don't seem to break anything. Have you verifies yourself that this fixes the issue mentioned in the JIRA? Still, I'd like other people's take on this, this is fickle stuff... @uce @iampeter @sachingoel0101. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol Thx! Could you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3093 These changes will be overridden the next time someone builds the web-dashboard. You have to modify the .jade files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
