[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3204 I vote to close this issue since #3492 has been merged/FLINK-4326 has been resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3204 @greghogan Definitely a misunderstanding, I had the impression you just didn't like my solution, so I didn't continue pushing for it (even if we finished with similar ideas). For ref, Greg's PR, so someone (a committer) reviews it https://github.com/apache/flink/pull/3351 I will move the docker scripts to use start-foreground once it is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3204 This is now looking like a game of hot potato :) I'm happy to let @iemejia create the PR but he had offered the same to me. If I don't hear otherwise first I'll create a PR for FLINK-4326. While sitting down so I don't step on anyone's toes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3204 Does anyone want to take a stab at addressing this the https://issues.apache.org/jira/browse/FLINK-4326 way? I think no one is active on that issue right now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/3204 Agreed.. If https://issues.apache.org/jira/browse/FLINK-4326 were merged this would also work fine. Whether or not Flink runs in the background or foreground is orthogonal to where the logs go â as long as Flink can be configured to log to stdout we're good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3204 I think @greghogan may be right - if the docker scripts are okay with running the Flink processes in the foreground, then https://issues.apache.org/jira/browse/FLINK-4326 seems like the more general solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3204 In regards to FLINK-4326, should the daemon scripts called by the docker script run in the foreground or background? It seems that this PR may be unnecessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3204 Looks good to me, +1 @uce the ScriptMeister should probably give his blessing as well... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---