[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 Awesome news! Thanks a lot @tzulitai for the great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3246 Manually merged with 3743e898104d79a9813d444d38fa9f86617bb5ef. Review happened in #3358. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3246 Hi @fpompermaier, sorry I was busy with other stuff over the last week. I hope to work towards merging this by the end of next week! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 Any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3246 Thanks for the feedbacks. I'll rebase this PR soon. @static-max thanks for the tip. I'll keep that in mind when updating the docs for this feature! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user static-max commented on the issue: https://github.com/apache/flink/pull/3246 Looks great! One note: In your example ExampleActionRequestFailureHandler you have to unwrap the Exception, as it is typical looks like: `RemoteTransportException[[Richard Rider][127.0.0.1:9301][indices:data/write/bulk[s]]]; nested: RemoteTransportException[[Richard Rider][127.0.0.1:9301][indices:data/write/bulk[s][p]]]; nested: EsRejectedExecutionException[rejected execution of org.elasticsearch.transport.TransportService$4@e5c47a1 on EsThreadPoolExecutor[bulk, queue capacity = 1, org.elasticsearch.common.util.concurrent.EsThreadPoolExecutor@7e2d5cc5[Running, pool size = 8, active threads = 8, queued tasks = 1, completed tasks = 119]]];` In my implementation I use Apache commons: ` ExceptionUtils.indexOfThrowable(throwable, EsRejectedExecutionException.class) >= 0 ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 I think that's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3246 @fpompermaier @static-max tagging you so that you're aware of this PR. Will be great to hear feedback from you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
