[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3297
  
@tonycox What do you think about my suggestion? If you agree, could you 
close this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3297
  
Not sure about this. This seems to implement in Flink what is actually the 
responsibility of the logger.

How about just updating the client such that there are two loggers 
configured: 
  1. The one that there is now (all internal stuff)
  2. The one that is used for status updates.

The status logger goes to file and console. You can customize the console 
logging in the logger config then.

That seems a better separation of concerns, and more generally extensible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-06 Thread tonycox
Github user tonycox commented on the issue:

https://github.com/apache/flink/pull/3297
  
@zentol What do you think about this PR ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---